feat(KFLUXVNGD-332): deploy smee-sidecar in production #6942
+187
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yftacherzog
force-pushed
the
smee-sidecar-to-prod
branch
from
65ae87e to
7406b42
Compare
yftacherzog
force-pushed
the
smee-sidecar-to-prod
branch
from
7406b42 to
e955b1d
Compare
|
/lgtm |
This change moves the manifests for deploying smee with the sidecar from the staging overlays (client and server) to the base, and having both staging and prod reference them. Signed-off-by: Yftach Herzog <[email protected]>
yftacherzog
force-pushed
the
smee-sidecar-to-prod
branch
from
e955b1d to
3313887
Compare
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avi-biton, ifireball, yftacherzog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Going to do this in smaller steps on multiple PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the manifests for deploying smee with the sidecar from the staging overlays (client and server) to the base, and having both staging and prod reference them.