This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix Route API version #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Depending on the tool and its version, v1 for Route may not be recognized, we faced it on the devworkspace controller side devfile/devworkspace-operator#187 (comment)
So, this PR replace v1 with full Route API version which is
route.openshift.io/v1.Also, it fixes deployments selector to avoid:
error when applying these resources.
Which issues does this PR references?
It should fix #65
Probably it does not fully fix but improve the situation for https://issues.redhat.com/browse/RHDEVDOCS-2154