Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

Conversation

sbouchet
Copy link
Collaborator

@sbouchet sbouchet commented Jun 2, 2021

What is the purpose of this change? What does it change?

Use the Kubernetes extension to switch context.

Was the change discussed in an issue?

fixes #319

How to test changes?

@sbouchet sbouchet requested a review from jeffmaury June 2, 2021 14:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021


<depends optional="true" config-file="withJava.xml">com.intellij.modules.java</depends>
<depends optional="true" config-file="withJavaScriptDebugger.xml">JavaScriptDebugger</depends>
<depends optional="true" config-file="plugin-json.xml">com.intellij.modules.json</depends>

<extensions defaultExtensionNs="com.intellij">
<!-- Add your extensions here -->
<toolWindow id="OpenShift" anchor="left" factoryClass="org.jboss.tools.intellij.openshift.WindowToolFactory" icon="/META-INF/pluginIcon13x13.svg"/>
<toolWindow id="OpenShift" anchor="left" factoryClass="org.jboss.tools.intellij.openshift.WindowToolFactory" icon="/META-INF/OpenShiftPluginIcon13x13.svg"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this renaming is worth it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had issues with the icons of the views when running my dev instance. both kubernetes and openshift had the same icon ( kube ). renaming it fixed it.

Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbouchet sbouchet merged commit fc09843 into redhat-developer:main Jun 3, 2021
@sbouchet sbouchet deleted the issue-319 branch June 3, 2021 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depend on Kubernetes extension for cluster managment
2 participants