This repository was archived by the owner on Apr 23, 2025. It is now read-only.
feat: Integrate alizer and improve create component workflow #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes redhat-developer#324 Signed-off-by: Jeff MAURY <[email protected]>
sbouchet
suggested changes
Jul 6, 2021
| @@ -274,7 +281,7 @@ private void loadModel() { | |||
| for (TreeNode nodeObject : Collections.list(rootNode.children())) { | |||
| DefaultMutableTreeNode node = (DefaultMutableTreeNode) nodeObject; | |||
| ComponentType type = (ComponentType) node.getUserObject(); | |||
| if (type.getName().equals(model.getComponentTypeName())) { | |||
| if (type.getName().equals(model.getSelectedComponentType().getName())) { | |||
There was a problem hiding this comment.
I ran into an issue where there is multiple registry with same name, and when I want to switch from the default selected one to another. the UI still select the first one.
test can be performed by duplicating the defualt registry and try to select the same component type in the duplicated registry.
- Match component types per registry - Select component type only for projects without devfile Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
|
SonarCloud Quality Gate failed. |
sbouchet
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
Signed-off-by: Jeff MAURY [email protected]
What is the purpose of this change? What does it change?
Was the change discussed in an issue?
fixes #???
How to test changes?