feat: add feedback dialog

[sbouchet]

What is the purpose of this change? What does it change?

Added a toolbar icon/action to share feedback using telemetry backend

Was the change discussed in an issue?

fixes #554

How to test changes?

[sbouchet]

/override ci/prow/e2e-4.11

[openshift-ci]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adietish]

I see the top section of the feedback dialog using a different font than the rest of the dialog:

I think that the dialog title bar would better show priorities if the icons and title would be reshuffled. Here's a suggestion:

[sbouchet]

I see the top section of the feedback dialog using a different font than the rest of the dialog: I think that the dialog title bar would better show priorities if the icons and title would be reshuffled. Here's a suggestion:

it's a webpage, taken from the vscode extension. @mohitsuman can you comment ?

[adietish]

I would also layout the labels/text area differently, following the jetbrains design guide

[adietish]

it's a webpage, taken from the vscode extension. @mohitsuman can you comment ?

If it's a web-page, why not open it in the browser like jetbrains do (choosing the menu item opens their web form)?

[adietish]

I have another suggestion: On top of the whole form I'd add a way to rate the product in a single click, like one can find in the jetbrains form, on amazon product reviews etc.

My justification is that I usually dont like "wasting" my time providing feedback (I especially dislike writing in free text areas. I only do it if I have a bug, a problem that I want to be fixed). But when I do it, I do it if I can to do it very quickly. With a star rating, a single click is enough. I'd think most developers are in this state of mind. We could thus increase feedback rates by providing the simplest possible feedback: a star-rating. And those that feel like providing more, they still can with the additional entries in the form.

[sbouchet]

by "webpage", i was referring to the webview implemented in vscode ( using a webpage input ) .
Your review made me think about removing that in favor of pure jface components.

[sbouchet]

I have another suggestion: On top of the whole form I'd add a way to rate the product in a single click, like one can find in the jetbrains form, on amazon product reviews etc. My justification is that I usually dont like "wasting" my time providing feedback (I especially dislike writing in free text areas. I only do it if I have a bug, a problem that I want to be fixed). But when I do it, I do it if I can to do it very quickly. With a star rating, a single click is enough. I'd think most developers are in this state of mind. We could thus increase feedback rates by providing the simplest possible feedback: a star-rating. And those that feel like providing more, they still can with the additional entries in the form.

overall, the first 3 items are mandatory, and for the sliderss, the comment area shows up only if score is below 3, but comment is not mandatory.
i'll try to make the first one mandatory only.

[sbouchet]

dialog is now looking like this.

[adietish]

@sbouchet: I simplified code that shows/hides components, made links for github and marketplace use non-serifed font and changed the positioning a bit. Hope you like it, otherwise just pick what the changes that you agree with and throw out the rest.

[sbouchet]

thank for the contributions ! i've added a margin to the left to better visual feedback when scrollbar is showed.

[sbouchet]

/override ci/prow/e2e-4.11

[openshift-ci]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbouchet]

/override ci/prow/e2e-4.11

[openshift-ci]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adietish]

I like your screenshot a lot. Quite an improvement, visually and usability-wise.
On MacOS though, icons are cropped. Futhermore I am wondering if "Have you used any similar extension..." wasn't better off with checkboxes, too?

[sbouchet]

new version with :

• aligned radio buttons for numbers
• radio for Yes/No similar extension question

image ratio is OK on Fedora with fix in ce6c029

[sbouchet]

/override ci/prow/e2e-4.11

[openshift-ci]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adietish]

In terms of widgets and icons/images it's now great imho. But I noticed a weird behavior where I'm wondering if it's intentional:

Steps:

1. ASSERT: "OK" button is disabled
2. EXEC: Provide some text in "4. What, if anything..."
3. ASSERT: "OK" button is disabled
4. EXEC: provide some text that's not an email (ex. "dddd") in "Share your contact..."
5. ASSERT: "OK" button is disabled, text field gets red with a balloon "The email format should be..."
6. EXEC: delete the text in "Share your contact..."

Result:
"OK" button is enabled.

Expected Result:
If providing text in "4. What, if anything..." is enough to have a valid form, shouldn't the "OK" button get enabled as soon as I provide text to it, not just after filling in invalid email and removing it again?

[sbouchet]

Fixed it. good catch !

[sbouchet]

/override ci/prow/e2e-4.11

[openshift-ci]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbouchet]

@mohitsuman see above comments for rendering on both Mac (from @adietish) and Linux/Fedora (@sbouchet)

[adietish]

@sbouchet I can still cause the "OK" button to get enabled when I add an invalid email and remove it again. Am I missing something?

[mohitsuman]

The UI looks good to merge.

[adietish]

The UI looks good to merge.

Yes, I agree, but you're still able to send empty forms.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[adietish]

@sbouchet added a check for content. OK is not enabled if there's no content. Please review.

[adietish]

@sbouchet added a check which makes sure that there's content in any of the widgets. Please review.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[sbouchet]

@sbouchet added a check which makes sure that there's content in any of the widgets. Please review.

nice ! works like a charm :)

[sbouchet]

/override ci/prow/e2e-4.11

[openshift-ci]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.