Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

feat: add helm support (#539) #590

Merged
merged 23 commits into from
Nov 3, 2023
Merged

feat: add helm support (#539) #590

merged 23 commits into from
Nov 3, 2023

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Oct 6, 2023

fixes #539

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish force-pushed the issue-539 branch 12 times, most recently from 66371e0 to d00edb3 Compare October 12, 2023 17:39
@adietish adietish force-pushed the issue-539 branch 6 times, most recently from f4d9a99 to 945eda3 Compare October 16, 2023 14:02
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@adietish adietish force-pushed the issue-539 branch 2 times, most recently from df4b175 to e008f22 Compare October 18, 2023 11:59
@adietish
Copy link
Contributor Author

adietish commented Oct 18, 2023 •
edited
Loading

That's how helm charts are listed:

  • a table listing the charts (grouping items by versions)
  • a text field for filtering which takes name, version, description (any column value) into account
  • a details pane that shows the item that's selected in the table where one can install it

image
@sbouchet, @datho7561 thoughts?
I guess that we could omit the versions in the table.

@datho7561
Copy link

I think it looks pretty good. I think dropping the Versions column in order to show more of the Description makes sense.

@adietish adietish changed the title feature: add helm support (#539) feat: add helm support (#539) Oct 18, 2023
@adietish adietish force-pushed the issue-539 branch 4 times, most recently from b849c13 to 7aa1b1b Compare October 19, 2023 16:01
@sbouchet
Copy link
Collaborator

sbouchet commented Nov 3, 2023

@adietish : last version works great ! the tree refresh on uninstall is smooth :)

sbouchet
sbouchet reviewed Nov 3, 2023
View reviewed changes
@adietish adietish requested a review from sbouchet November 3, 2023 09:17
@adietish
Copy link
Contributor Author

adietish commented Nov 3, 2023

It would be nice to be able to navigate the table that contains the charts by pressind cursor up & down. I'll file an enhancement issue.

sbouchet
sbouchet reviewed Nov 3, 2023
View reviewed changes
sbouchet
sbouchet reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overral LGTM, small changes needed

@adietish
Copy link
Contributor Author

adietish commented Nov 3, 2023

@sbouchet I'm looking into the failing IT. Shouldn't we fix it before merging?

@adietish adietish requested a review from sbouchet November 3, 2023 10:14
@adietish
fixed complaints by sbouchet
6aaff21 
Signed-off-by: Andre Dietisheim <[email protected]>
@sbouchet
Copy link
Collaborator

sbouchet commented Nov 3, 2023

@sbouchet I'm looking into the failing IT. Shouldn't we fix it before merging?

no, it's part of the UI integration Test, that are new, added by #535 , and failling since.

@adietish
Copy link
Contributor Author

adietish commented Nov 3, 2023 •
edited
Loading

no, it's part of the UI integration Test, that are new, added by #535 , and failling since.

@sbouchet ok, please re-approve it then and I then merge it 🎉

sbouchet
sbouchet approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work on this !

@openshift-ci openshift-ci bot added the lgtm label Nov 3, 2023
@adietish
Copy link
Contributor Author

adietish commented Nov 3, 2023 •
edited
Loading

LGTM, good work on this !

thanks 😄 appreciate 😄

@adietish adietish removed the request for review from datho7561 November 3, 2023 14:58
@adietish
Copy link
Contributor Author

adietish commented Nov 3, 2023

/override ci/prow/e2e-4.11

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 3, 2023

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish adietish merged commit cfea2dc into redhat-developer:main Nov 3, 2023
@adietish adietish deleted the issue-539 branch November 3, 2023 15:27
This was referenced Nov 6, 2023
Closed
Open
Open
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@sbouchet sbouchet sbouchet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sbouchet sbouchet

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Helm Chart support similar to VSCode OpenShift Toolkit
3 participants
@adietish @datho7561 @sbouchet