feat: validate new project name (#237)

[adietish]

fixes #237, #674, #701
depends on #661

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[sbouchet]

Same remark as #689 . is it possible to change labels if the cluster is openshift(project) or kubernetes(namespace) ?

[sbouchet]

Same remark as #689 . is it possible to change labels if the cluster is openshift(project) or kubernetes(namespace) ?

created #701 for fixing actions labels only.

[adietish]

I merged and squashed #701 into this PR (adding your "signed-off by") as providing different labels for kubernetes/openshift is closely related to the labels of the menu items to launch it.

[adietish]

@sbouchet: please re-review.

[sbouchet]

@sbouchet:

there is no update on ChangeActiveProjectAction, thus the label is always 'project'.

I cannot replicate your issue. Things are working fine for me when switching from kind to crc.

Screen.Recording.2024-02-08.at.20.17.39.mov
What am I missing?

look at 0:13. this is not the "create" label, but the "Change " one that is always displaying "Project". there is a missing update() method in the ChangeAction.

[adietish]

@sbouchet:

look at 0:13. this is not the "create" label, but the "Change " one that is always displaying "Project". there is a missing update() method in the ChangeAction.

This PR is about the "New Project" dialog, not the "Change Project" dialog 😃
So this is a different issue, I'll file and fix it.

[adietish]

@sbouchet 👍 gotcha, this was included in your PR for #701. Adding it here, too.

[adietish]

@sbouchet please re-review, thanks!

[sbouchet]

left two places with "project" when using kubernetes cluster.

• one on validation message on dialog
• one on missing project/namespace message on tree

[adietish]

@sbouchet fixed those 2, please re-review.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[sbouchet]

LGTM

[adietish]

/override ci/prow/e2e-openshift

[openshift-ci]

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adietish]

/override tide

[openshift-ci]

@adietish: Overrode contexts on behalf of adietish: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbouchet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment