Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

fix: show 'missing project' - not 'log in' - when current is inexistant (#715, #719) #722

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: show 'missing project' - not 'log in' - when current is inexistant (#715, #719) #722

merged 1 commit into from
Feb 27, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Feb 27, 2024 •
edited
Loading

fixes #715
fixes #719

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish self-assigned this Feb 27, 2024
@adietish adietish marked this pull request as ready for review February 27, 2024 08:28
@adietish adietish mentioned this pull request Feb 27, 2024
Closed
@adietish adietish changed the title fix: show 'missing project' - not log in - when current is inexistant (#715) fix: show 'missing project' - not log in - when current is inexistant (#715, #719) Feb 27, 2024
@adietish adietish changed the title fix: show 'missing project' - not log in - when current is inexistant (#715, #719) fix: show 'missing project' - not 'log in' - when current is inexistant (#715, #719) Feb 27, 2024
martinszuc
martinszuc approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@martinszuc martinszuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes successfully, looks great to me.

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2024
@openshift-ci openshift-ci bot removed the lgtm label Feb 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

New changes are detected. LGTM label has been removed.

@adietish
Copy link
Contributor Author

rebased, re-adding "approved" etc.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: martinszuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish adietish added the lgtm label Feb 27, 2024
@martinszuc martinszuc mentioned this pull request Feb 27, 2024
Closed
@openshift-ci openshift-ci bot removed the lgtm label Feb 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

New changes are detected. LGTM label has been removed.

@adietish adietish added the lgtm label Feb 27, 2024
@redhat-developer redhat-developer deleted a comment from openshift-ci bot Feb 27, 2024
@adietish
Copy link
Contributor Author

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@openshift-merge-bot openshift-merge-bot bot merged commit ba50305 into redhat-developer:main Feb 27, 2024
@adietish adietish deleted the issue-715 branch February 27, 2024 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbouchet sbouchet Awaiting requested review from sbouchet

1 more reviewer

@martinszuc martinszuc martinszuc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@adietish adietish

@martinszuc martinszuc

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Missing 'No project available' when logged in to a cluster with no project. bug: Changing current active project to a non-existent one
2 participants
@adietish @martinszuc