Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

fix: can't stop dev on component after switching to a different project #728

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: can't stop dev on component after switching to a different project #728

merged 2 commits into from
Mar 19, 2024

Conversation

sbouchet
Copy link
Collaborator

@sbouchet sbouchet commented Feb 29, 2024 •
edited
Loading

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #537
fixes #634

How to test changes?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sbouchet
Copy link
Collaborator Author

@adietich: i've done some quite big refactor, and not very happy with some method signatures on odo interface.
WDYT ?

sbouchet
sbouchet commented Feb 29, 2024
View reviewed changes
src/main/java/org/jboss/tools/intellij/openshift/tree/application/ApplicationRootNodeOdo.java
}

private void updateComponent(String project, String path, ComponentDescriptor componentDescriptor, Component component) throws IOException {
component.setPath(path);
ComponentInfo info = getComponentInfo(project, componentDescriptor.getName(), path, ComponentKind.DEVFILE);
component.setInfo(info);
Map<ComponentFeature, ProcessHandler> componentMap = getComponentFeature(component.getName());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actual fix of #537 resides here

@sbouchet
Copy link
Collaborator Author

sbouchet commented Mar 1, 2024

this will also address some of #169

@sbouchet sbouchet marked this pull request as ready for review March 14, 2024 14:32
@openshift-ci openshift-ci bot requested a review from adietish March 14, 2024 14:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0ff5281 into redhat-developer:main Mar 19, 2024
@sbouchet sbouchet deleted the issue-537 branch March 19, 2024 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@adietish adietish adietish approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@adietish adietish

@sbouchet sbouchet

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refreshing view makes me unable to stop the dev on component Can't stop dev on component after switching to a different project
2 participants
@sbouchet @adietish