Skip to content

feat(app-next): app-next initial spike #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gashcrumb
Copy link
Member

@gashcrumb gashcrumb commented Jun 26, 2025

This change introduces the new frontend system by adding a new app-next package. This new frontend can co-exist alongside the previous frontend system and is enabled by setting the following environment variable:

export APP_CONFIG_app_packageName=app-next

before starting the RHDH backend. An additional start:next script has been added to the backend package, and it is also possible to use this environment variable to select the new frontend when using the RHDH container.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@gashcrumb gashcrumb force-pushed the RHIDP-6880 branch 2 times, most recently from 9b7ee5f to 7d6ea7b Compare June 26, 2025 18:11
@gashcrumb gashcrumb marked this pull request as draft June 26, 2025 18:17
Copy link
Contributor

@gashcrumb gashcrumb marked this pull request as ready for review June 27, 2025 10:12
@gashcrumb gashcrumb force-pushed the RHIDP-6880 branch 2 times, most recently from 81dbf22 to 892e7da Compare June 27, 2025 10:26
Copy link
Contributor

Copy link

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pataknight for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Jul 3, 2025

@gashcrumb
Copy link
Member Author

/retest

1 similar comment
@gashcrumb
Copy link
Member Author

/retest

Copy link
Contributor

github-actions bot commented Jul 7, 2025

@gashcrumb
Copy link
Member Author

/retest

1 similar comment
@gashcrumb
Copy link
Member Author

/retest

@gashcrumb gashcrumb force-pushed the RHIDP-6880 branch 3 times, most recently from 67da63a to 89da9bd Compare July 10, 2025 11:47
Copy link
Contributor

@gashcrumb
Copy link
Member Author

/retest

3 similar comments
@gashcrumb
Copy link
Member Author

/retest

@gashcrumb
Copy link
Member Author

/retest

@gashcrumb
Copy link
Member Author

/retest

@gashcrumb
Copy link
Member Author

/retest

1 similar comment
@gashcrumb
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Jul 10, 2025

@gashcrumb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests-sealight-helm-nightly 25a61f7 link false /test e2e-tests-sealight-helm-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

This change introduces the new frontend system by adding a new app-next
package.  This new frontend can co-exist alongside the previous frontend
system and is enabled by setting the following environment variable:

```bash
export APP_CONFIG_app_packageName=app-next
```

before starting the RHDH backend.  An additional start:next script has
been added to the backend package, and it is also possible to use this
environment variable to select the new frontend when using the RHDH
container.

Signed-off-by: Stan Lewis <[email protected]>
Assisted-by: Cursor Desktop
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant