Skip to content

chore: add default configs for ldap dynamic plugin #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JessicaJHee
Copy link
Member

Description

Add default configs for LDAP dynamic plugin so that when the plugin is enabled (disabled: true), the user only needs to provide the following env vars for the plugin to work:

  • LDAP_TARGET_URL
  • LDAP_BIND_DN
  • LDAP_BIND_SECRET
  • LDAP_USERS_DN
  • LDAP_GROUPS_DN

Also filters out users without uid and groups without cn, which are required for default LDAP ingestion since those params are used to populate metadata.name by default

Relates to RHIDP-6681

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Set up ingestion with the LDAP plugin with the built image

Copy link
Contributor

github-actions bot commented Jul 4, 2025

@albarbaro
Copy link
Member

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albarbaro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 8, 2025
@JessicaJHee JessicaJHee force-pushed the ldap-dynamic-defaults branch from 0477dea to aead49a Compare July 8, 2025 21:28
@openshift-ci openshift-ci bot removed the lgtm label Jul 8, 2025
Copy link

openshift-ci bot commented Jul 8, 2025

New changes are detected. LGTM label has been removed.

Copy link
Contributor

github-actions bot commented Jul 8, 2025

@JessicaJHee
Copy link
Member Author

/test e2e-tests-auth-providers-nightly

@JessicaJHee JessicaJHee force-pushed the ldap-dynamic-defaults branch from aead49a to 7db8de2 Compare July 9, 2025 14:02
Copy link
Contributor

github-actions bot commented Jul 9, 2025

@JessicaJHee
Copy link
Member Author

/test e2e-tests-auth-providers-nightly

Copy link
Contributor

Copy link
Contributor

@JessicaJHee
Copy link
Member Author

/test e2e-tests-auth-providers-nightly

Copy link
Contributor

@JessicaJHee JessicaJHee requested a review from kim-tsao July 11, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants