[🚫 Bug] extension: Error occurred while scanning secrets (files): Error: EISDIR: illegal operation on a directory, read

[ssbarnea]

Describe the bug

Apparently trying to run the tests from wihting extest extension caused a fatal error seen below.

Steps to reproduce

-

Logs

=> Run vsce ls --tree to see all included files.

 ERROR  Error occurred while scanning secrets (files): Error: EISDIR: illegal operation on a directory, read
    at async readFileHandle (node:internal/fs/promises:557:24)
    at async createRawSource (file:///Users/ssbarnea/code/a/devtools/vscode-ansible/node_modules/@secretlint/source-creator/module/index.js:16:21)
    at async lintFile (file:///Users/ssbarnea/code/a/devtools/vscode-ansible/node_modules/@secretlint/node/module/index.js:15:23)
    at async mapper (file:///Users/ssbarnea/code/a/devtools/vscode-ansible/node_modules/@secretlint/node/module/index.js:63:24)
    at async file:///Users/ssbarnea/code/a/devtools/vscode-ansible/node_modules/p-map/index.js:121:20 {
  errno: -21,
  code: 'EISDIR',
  syscall: 'read'
}

 *  The terminal process "/opt/homebrew/bin/zsh '-l', '-c', 'npx extest setup-and-run '/Users/ssbarnea/code/a/devtools/vscode-ansible/zz/test/ui-test/one.test.js' --code_version max --type stable'" terminated with exit code: 1. 
 *  Terminal will be reused by tasks, press any key to close it.

Operating System

Visual Studio Code

vscode-extension-tester

0.1.2 (extension, cli is the latest)

NodeJS

22

npm

No response

[ssbarnea]

This is caused by a bug in vsce package which would fail ugly when it encounters any symlinked directories inside the list of files used to be included when building the package.

While vsce package --follow-symlinks can be used to build a package that use these, there are other commands that would fail due to this bug, more exactly the vsce ls --tree

The good news is that I found an ugly workaround that can be seen on ansible/vscode-ansible#2433