New imports are added before folded ones when using editor.foldingImportsByDefault

[mamilic]

When I autoimport the suggested claasname, prior to enabling the fold imports, it will add new import before folded ones.

Environment

• Operating System: Windows 11
• JDK version: 21
• Visual Studio Code version: 1.94.2
• Java extension version: 1.35.1

Steps:

1. Open demo.zip
2. Navigate to DemoApplication.java and try to add new import by typing claas name instead of ArrayList by autocompleting the classname.
3. It will add new import before the folded ones

[rgrunber]

The import order is determined by

vscode-java/package.json

Lines 1120 to 1133 in cc32926

	"java.completion.importOrder": {
	"type": "array",
	"description": "Defines the sorting order of import statements. A package or type name prefix (e.g. 'org.eclipse') is a valid entry. An import is always added to the most specific group. As a result, the empty string (e.g. '') can be used to group all other imports. Static imports are prefixed with a '#'",
	"default": [
	"#",
	"java",
	"javax",
	"org",
	"com",
	""
	],
	"scope": "window",
	"order": 80
	},

So the imports starting with "java" will be placed above those starting with "org", in addition to whitespace to indicate they are a separate grouping. You could remove the "org" imports and add them back in to see they are placed below.

[mamilic]

Hi @rgrunber , thank you for the info. I do apologies If I forgot to mention that folding imports is turned on in settings. I am wondering how the imports should behave if imports are folded, and new import is added by autocompletion? Should it be added before the folded ones or inside the folded block?

[rgrunber]

Yup, you're right. So if editor.foldingImportsByDefault is enabled, and the imports are fully collapsed, adding a new import never gets "auto-collapsed" into the existing collapsed import fold. Even after clearing the editor history, it still remembers the fold. The language server is correctly defining the new import fold range, but I'm still seeing the previous folding range in the UI. You can even see it in your screenshot (the 2 folds). The only way I'm able to get things folded again is by Toggle Import Fold (editor.toggleImportFold) from the command palette, or by using a completely fresh vscode instance 😜 .

Maybe the folding history is saved for each editor and it conflicts with the ability to update the fold automatically. @jdneo , can you reproduce this ? If toggling the import fold manually can fix this, I would think it's a bug in the automated logic in VS Code for editor.foldingImportsByDefault. Thoughts ?

[mamilic]

@rgrunber , thank you for detail explanation. There is issue already opened against vscode, microsoft/vscode#192775. However I wasn't sure whether this issue was related to this repo.