Support publishing pre-release versions

[CsCherrYY]

fix #2285

Notes:

• For the trigger part, I'm not sure the current trigger of Jenkins pipeline since it's on the Jenkins server, I suppose we trigger this pipeline after there is a commit to the vscode-java or eclipse.jdt.ls repository, so in this PR I add a trigger in the scripted pipeline to nightly build when there is SCM changes, if we can merge the configuration with that in the current Jenkins server that would be fine. @rgrunber any comments?
• Due to the requirement of pre-release channel (see Support publishing pre-release versions #2285 (comment)), a tool node 14.x should be added to the Jenkins server (in this PR it's nodejs-14.19.1) and we will use the newest version of vsce.
• Validation: for the pre-release versions, the packaged vsix file has an 'extension.manifest' file in its root path, and in that file, we can find

<Property` Id="Microsoft.VisualStudio.Code.PreRelease" Value="true" />

Signed-off-by: Shi Chen [email protected]

[CsCherrYY]

test this please

[rgrunber]

The Jenkinsfile inherits from a parent definition that polls SCM every 2 minutes for a change. @fbricon brought up the fact that it makes more sense to do it nightly to avoid the case of potentially updating the insider build multiple times (and forcing multiple downloads) per day. I agree, and we can probably make that change.

[CsCherrYY]

Sounds great. In this way, we will not make any SCM trigger change in this PR but it will happen on the server side, is that right? if so, I can remove this part then.

[CsCherrYY]

@rgrunber I have removed the SCM trigger part in the Jenkins file.

For the node version and vsce version part, is there any gap in using node 14.x for publishing now?

[CsCherrYY]

The newest commit I just separate the pre-release pipeline and keep the current builds work. All we should do in the Jenkins server are:

• Create a new pipeline, and target this repository
• Set the SCM trigger to daily build if new commit comes
• Copy the environment variables and credentials from the existing pipeline, without publishToMarketPlace. Instead, create a new variable publishPreRelease and set it to true.

[testforstephen]

LGTM

[testforstephen]

@rgrunber there are two follow-ups for you:

• Install nodejs-14.19.1 in CI machine.

• Create a new pipeline for pre-release, see more details from @CsCherrYY comment above.

  The newest commit I just separate the pre-release pipeline and keep the current builds work. All we should do in the Jenkins server are:

  • Create a new pipeline, and target this repository
  • Set the SCM trigger to daily build if new commit comes
  • Copy the environment variables and credentials from the existing pipeline, without publishToMarketPlace. Instead, create a new variable publishPreRelease and set it to true.

[CsCherrYY]

@rgrunber Could you please verify this change in the Jenkins server? If there is anything I can help, feel free to reach out🙂

[rgrunber]

• The build seems to work as expected with nodejs-14.19.1 🚀 . I can confirm presence of <Property Id="Microsoft.VisualStudio.Code.PreRelease" Value="true" />
• I would also modify the ovsx@<0.3.0 reference to just ovsx . Same situation as vsce ( eclipse/openvsx@f5cc1a9 )
• I just need to create a PR on our end to add publishPreRelease (default true) as a parameter & to see how we can modify the job so it runs daily.

[rgrunber]

Just one minor thing to fix, but overall, works.

• I think you re-introduced the "ovsx@<0.3.0" line. Just make it "ovsx". With node 14 we don't need to restrict it.

Just as a note, the Jenkins job has been configured to use an scmpoll_spec of '0 8 * * *' so it will build once per day only if there are new changes. We can play with this later if necessary.

[CsCherrYY]

@rgrunber Sounds great! I have removed the version striction of ovsx. We can start to play with it.