Fix index creation issue when multiple options are used with fields #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add missing xml doc for parameters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the index creation issue that occurs when multiple options are used with field definitions. The changes reposition the "SORTABLE" flag in the search tests and schema construction while adding tests to validate the updated behavior.
- Adjust the ordering of command arguments by moving the "SORTABLE" option in the schema and search command builder.
- Introduce new tests in IndexCreationTests to verify behavior when missing, empty, and sortable fields are involved.
- Update XML documentation comments for field creation methods to include details on missing and empty index options.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/NRedisStack.Tests/Search/SearchTests.cs | Reordering of the "SORTABLE" option in field commands |
| tests/NRedisStack.Tests/Search/IndexCreationTests.cs | New tests added to verify index creation with missing/empty/sortable fields |
| src/NRedisStack/Search/Schema.cs | Adjusted ordering of options (SORTABLE, INDEXMISSING, INDEXEMPTY) and updated XML docs |
atakavci
added a commit
to atakavci/NRedisStack
that referenced
this pull request
Apr 11, 2025
…edis#405) * - change order of field options in search&query - add missing xml doc for parameters * fix search tests * fix format
atakavci
added a commit
to atakavci/NRedisStack
that referenced
this pull request
Apr 14, 2025
…edis#405) * - change order of field options in search&query - add missing xml doc for parameters * fix search tests * fix format
atakavci
added a commit
to atakavci/NRedisStack
that referenced
this pull request
Apr 14, 2025
…edis#405) * - change order of field options in search&query - add missing xml doc for parameters * fix search tests * fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Closes #404