Skip to content

Feature/hook new #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2019
Merged

Feature/hook new #1040

merged 5 commits into from
Jun 1, 2019

Conversation

vmihailenco
Copy link
Collaborator

No description provided.

@vmihailenco vmihailenco force-pushed the feature/hook-new branch 2 times, most recently from d7cded4 to 10a091a Compare June 1, 2019 08:04
@vmihailenco vmihailenco merged commit 17480c5 into dev Jun 1, 2019
@vmihailenco vmihailenco deleted the feature/hook-new branch June 1, 2019 08:50
@e-zhang
Copy link

e-zhang commented Jul 3, 2019

@vmihailenco I think the change to replace .clone() with *c resulted in the c.cmdable still being bounded to the previous c.Process as a result the return from WithContext returns a client that on .Process still uses the old ctx or nil if it does not exist.

Is this intended behavior?

@vmihailenco vmihailenco mentioned this pull request Jul 4, 2019
Merged
@vmihailenco
Copy link
Collaborator Author

@e-zhang You are right - should be fixed in #1080

vmihailenco added a commit that referenced this pull request Mar 11, 2020
@vmihailenco
Merge pull request #1040 from go-redis/feature/hook-new
6178b20 
Feature/hook new
@notrobpike notrobpike mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmihailenco @e-zhang