Skip to content

fix test error #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2021
Merged

fix test error #1696

merged 2 commits into from
Mar 16, 2021

Conversation

monkey92t
Copy link
Collaborator

fix test error:

The critical value of time may appear to cause test errors, link: https://github.com/redis/redis/blob/5b48d900498c85bbf4772c1d466c214439888115/src/object.c#L1265-L1272

Failure [0.068 seconds]
Commands
/redis/commands_test.go:17
  keys
  /redis/commands_test.go:304
    should Object [It]
    /redis/commands_test.go:462

    Expected
        <time.Duration>: 1000000000
    to equal
        <time.Duration>: 0

    /redis/commands_test.go:473

In addition, I tracked down more test errors: CLUSTERDOWN The cluster is down.
but I can't determine the cause for the time being. It may be redis-server instability or go-redis cluster problems. I will keep track of them.

I still can't reproduce #1657, maybe it's a problem with my test environment?
The go developers said that it might be a problem with pool: sync.pool{}, but they can’t confirm it.
We can wait for the go developers’ investigation results, link: golang/go#44672

@monkey92t monkey92t changed the title Test error fix test error Mar 14, 2021
@vmihailenco
Copy link
Collaborator

Thanks 👍

@vmihailenco vmihailenco merged commit 7ba7ac4 into redis:master Mar 16, 2021
@vmihailenco
Copy link
Collaborator

We can wait for the go developers’ investigation results, link: golang/go#44672

Let's keep discussion in #1657. Hopefully we will accumulate enough data to get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants