Implement hexpire for #1898 #1918
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Any update for this PR? It would be awesome to integrate this feature in the next release 💪 |
PavelPashov
requested changes
Jun 17, 2025
| const CUSTOM_PROPERTY = "_myCustomProperty"; | ||
|
|
||
| describe("hexpire", () => { | ||
| beforeEach(() => { |
There was a problem hiding this comment.
This seems irrelevant to the hexpire command
| }); | ||
| }); | ||
|
|
||
| afterEach(() => { |
There was a problem hiding this comment.
This seems irrelevant to the hexpire command
| delete (Object.prototype as any)[CUSTOM_PROPERTY]; | ||
| }); | ||
|
|
||
| it("should handle special field names", async () => { |
There was a problem hiding this comment.
Please create a test that verifies all possible return types from the server listed here: https://redis.io/docs/latest/commands/hexpire/
| numFields: number, | ||
| ...fieldValues: string[] | ||
| ] | ||
| ): Result<"OK", Context>; |
There was a problem hiding this comment.
This return type is incorrect, should be Result<number[], Context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
hexpirecommand for #1898Will require an update to
@ioredis/commandsfrom this PR ioredis/commands#3