-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Expose method to add upstream driver libraries to CLIENT SETINFO payload #4373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ggivo
merged 5 commits into
redis:master
from
viktoriya-kutsarova:expose-methods-to-identify-upstream-drivers
Dec 10, 2025
Merged
Expose method to add upstream driver libraries to CLIENT SETINFO payload #4373
ggivo
merged 5 commits into
redis:master
from
viktoriya-kutsarova:expose-methods-to-identify-upstream-drivers
Dec 10, 2025
+646
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishun
previously approved these changes
Dec 5, 2025
Contributor
tishun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ggivo
reviewed
Dec 6, 2025
f751774 to
3300bc3
Compare
ggivo
previously approved these changes
Dec 9, 2025
Collaborator
ggivo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ggivo
previously approved these changes
Dec 9, 2025
ggivo
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for attaching upstream driver library information to the CLIENT SETINFO command.
Changes:
Introduced a DriverInfo class with builder pattern to hold driver information and upstream drivers, providing validation and formatting. Updated ClientSetInfoConfig to use DriverInfo for appending upstream drivers, chaining on top of existing configurations, and optionally overriding the full driver name.
Why we need the change:
Some drivers, frameworks, or SDK layers are built on top of this client and need a way to report their own library identifiers to Redis. This helps improve observability, analytics, and troubleshooting by making the client stack visible through CLIENT LIST and related introspection commands.