Skip to content

Add "username" setting support to Sentinel mode #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
georgelupu opened this issue Dec 20, 2022 · 3 comments
Closed

Add "username" setting support to Sentinel mode #2285

georgelupu opened this issue Dec 20, 2022 · 3 comments
Labels
status: good-first-issue An issue that can only be worked on by brand new contributors type: feature A new feature
Milestone

Comments

@georgelupu
Copy link

georgelupu commented Dec 20, 2022

Feature Request

Add "setSentinelUsername" method to Sentinel mode

Is your feature request related to a problem? Please describe

Latest Redis (6+) servers have ACL support which allows us to have in the database other users than the "default" one, but the current Lettuce client driver implementation does not allow to provide the "username" under RedisSentinelConfiguration class.
As result only the "default" db user can be used with the Lettuce driver in order to connect to Sentinel - which is a concern for DBOps folks who do not want to share "default" root/admin account with the application developers.

Describe the solution you'd like

Today, we can only provide setSentinelPassword config in RedisSentinelConfiguration class.
Please add "setSentinelUsername" method support as well. Thank you!

Describe alternatives you've considered

No alternatives are available at the moment except using the "default" redis db user for connecting to Sentinel.

@mp911de mp911de added the status: good-first-issue An issue that can only be worked on by brand new contributors label Dec 13, 2023
@castlering97
Copy link

Hi @mp911de. I would like to work on this issue if it's okay.
(And I am a beginner in open source, so I would be really glad if you could give me any kind of guidance =])

@tishun tishun added this to the Backlog milestone Jun 12, 2024
@tishun
Copy link
Collaborator

tishun commented Jun 12, 2024

Hi @mp911de. I would like to work on this issue if it's okay. (And I am a beginner in open source, so I would be really glad if you could give me any kind of guidance =])

Please submit a PR if you are still considering working on this. To do so the typical approach would be:

  • fork the repository
  • create a branchin your own fork for the fix (also known as topic branch)
  • after you are ready locally you need to push to your forked branch
  • when the push is done in the result you will get a link to file a pull request
  • check out some of the existing pull requests for examples

@tishun tishun added the type: feature A new feature label Jun 12, 2024
@ggivo
Copy link
Contributor

ggivo commented Oct 28, 2024

Referred configuration class RedisSentinelConfiguration is actually part of spring-data-redis.

It looks like support for providing a sentinel username in addition to the password is already added with commit
closing issue

Here is also more up-to-date link to RedisSentinelConfiguration (Spring Data Redis 3.3.5 API)

@ggivo ggivo closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: good-first-issue An issue that can only be worked on by brand new contributors type: feature A new feature
Projects
None yet
Development

No branches or pull requests

5 participants