Skip to content

Add username support for Sentinel Configuration #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vikasgarghb opened this issue Jan 3, 2022 · 1 comment
Closed

Add username support for Sentinel Configuration #2218

vikasgarghb opened this issue Jan 3, 2022 · 1 comment
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
2.7 M1 (2021.2.0)

Comments

@vikasgarghb
Copy link
Contributor

In order to use authentication on sentinel using ACLs there needs to be support added on sentinel configuration for Lettuce. Similar to what has been done on spring-boot: spring-projects/spring-boot@36382e5
@mp911de mp911de added the type: enhancement A general enhancement label Jan 4, 2022
@vikasgarghb vikasgarghb mentioned this issue Jan 4, 2022
Closed
@mp911de mp911de added this to the 2.7 M1 (2021.2.0) milestone Jan 7, 2022
@mp911de mp911de self-assigned this Jan 7, 2022
@mp911de mp911de changed the title Add username support for Lettuce Sentinel Configuration Add username support for Sentinel Configuration Jan 7, 2022
@mp911de mp911de closed this as completed in f333b18 Jan 7, 2022
mp911de added a commit that referenced this issue Jan 7, 2022
@mp911de
Polishing.
d0f17b1 
Reformat code. Consider sentinel username in JedisConnectionFactory. Update years in license headers.

See #2218
Original pull request: #2224.
@mourezwell
Copy link

is there a plan to expand this enhancement to spring-boot, in deed org.springframework.boot.autoconfigure.data.redis.RedisProperties does not support sentinel username yet,
so does org.springframework.boot.autoconfigure.data.redis.RedisConnectionConfiguration can't set SentinelUsernma you've just added here ?

This was referenced Feb 4, 2022
Closed
Closed
@GSvensk GSvensk mentioned this issue May 4, 2022
Closed
@ggivo ggivo mentioned this issue Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.7 M1 (2021.2.0)
Development

No branches or pull requests
3 participants
@mp911de @vikasgarghb @mourezwell