Repository navigation
Upgrade javaparser-core to 3.28.0 - #3948
Conversation
Since 3.13.0 the static JavaParser.parse(...) methods live in StaticJavaParser, so bumping the version alone fails to compile. JavadocConsistencyUnitTests is the only remaining user of the library after the generators were removed in redis#3866. Switch its two call sites to StaticJavaParser.parse(File).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f3f9521de
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <groupId>com.github.javaparser</groupId> | ||
| <artifactId>javaparser-core</artifactId> | ||
| <version>3.6.3</version> | ||
| <version>3.28.0</version> |
There was a problem hiding this comment.
Under the repository's normal JDK 8 build (the reusable test workflow leaves java_version at its default 8 in .github/workflows/run-tests.yml:22-26), javaparser-core:3.28.0 cannot be loaded because its published classes require a post-Java-8 class-file level. Test compilation reaches the new StaticJavaParser import and aborts with an unsupported class-version error, so every default CI matrix entry fails before tests run; use the newest JavaParser release that still targets Java 8 unless the project baseline and workflows are raised together.
AGENTS.md reference: AGENTS.md:L61-L64
Useful? React with 👍 / 👎.
Closes #3073
javaparser-core is still on 3.6.3 (April 2018). Since 3.13.0 the static
JavaParser.parse(...)methods live inStaticJavaParser, so bumping theversion alone fails to compile in
JavadocConsistencyUnitTests, which isthe only remaining user of the library now that the generators are gone (#3866).
This bumps the version and switches the two call sites to
StaticJavaParser.parse(File). No other API changes were needed.Validation:
mvn test -Dtest=JavadocConsistencyUnitTestspasses on 3.6.3 before and on 3.28.0 after.removed one
@deprecatedtag inRedisStringCommandsand the test failed as expected.This should also make #3628 unnecessary.
Note
Low Risk
Test-only dependency bump with a small API rename; no production or client-facing behavior changes.
Overview
Upgrades the test-scoped
javaparser-coredependency from 3.6.3 to 3.28.0 inpom.xml.Because JavaParser moved static
parse(...)entry points toStaticJavaParser(since 3.13.0),JavadocConsistencyUnitTestsnow importsStaticJavaParserand usesStaticJavaParser.parse(source)in the two places that walk command-interface sources for Javadoc/deprecation checks. Runtime/library code is unchanged; this only affects the consistency test that parses Java sources.Reviewed by Cursor Bugbot for commit d4fd693. Bugbot is set up for automated code reviews on this repo. Configure here.