executeIsolated causes uncaughtException when client connection resets

[tugtugtug]

The pooled clients are not handling any of the errors emitted by the socket via

node-redis/packages/client/lib/client/socket.ts

Line 182 in 741aff0

this.#onSocketError(new SocketClosedUnexpectedlyError());

and is causing node to report these as uncaughtException and abort the process.

So, as soon as executeIsolated gets called, which starts a pooled client, and if the connected server goes away, the client will die with an uncaughtException due to the exception thrown by the socket above.

2022-03-16T20:39:58.139Z error: uncaughtException: Socket closed unexpectedly
Error: Socket closed unexpectedly
    at Socket.<anonymous> (/test/node_modules/@node-redis/client/dist/lib/client/socket.js:182:118)
    at Object.onceWrapper (events.js:520:26)
    at Socket.emit (events.js:400:28)
    at TCP.<anonymous> (net.js:686:12)

Environment:

• Node.js Version: v14.19.0
• Redis Server Version: 6.0.5
• Node Redis Version: [email protected]
• Platform: debian bullseye

[kpturner]

I am using version 4.0.6 and I still get this problem

SocketClosedUnexpectedlyError: Socket closed unexpectedly
    at Socket.<anonymous> (.../node_modules/@node-redis/client/dist/lib/client/socket.js:182:118)
    at Object.onceWrapper (node:events:510:26)
    at Socket.emit (node:events:390:28)
    at Socket.emit (node:domain:475:12)
    at TCP.<anonymous> (node:net:687:12)
    at TCP.callbackTrampoline (node:internal/async_hooks:130:17)

The error handler on the client does not fire.

EDIT - Ahh - I am using duplicate to create subscriptions and if I add a listener there it fires on both the parent and the duplicate. But if I do not add a listener on the duplicate nothing fires at all.