Skip to content

fix #1846 - handle arguments that are not buffers or strings #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

leibale
Copy link
Contributor

@leibale leibale commented Jan 19, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #1849 (346435f) into master (2ff7084) will increase coverage by 0.04%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
+ Coverage   95.05%   95.09%   +0.04%     
==========================================
  Files         353      353              
  Lines        3314     3305       -9     
  Branches      407      404       -3     
==========================================
- Hits         3150     3143       -7     
+ Misses         81       80       -1     
+ Partials       83       82       -1     
Impacted Files Coverage Δ
packages/client/lib/client/commands-queue.ts 80.79% <0.00%> (-0.13%) ⬇️
packages/client/lib/client/index.ts 87.38% <100.00%> (ø)
packages/client/lib/client/multi-command.ts 85.41% <100.00%> (ø)
packages/client/lib/client/socket.ts 78.18% <100.00%> (+1.60%) ⬆️
packages/client/lib/commander.ts 96.36% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff7084...346435f. Read the comment docs.

@leibale leibale added the Bug label Jan 19, 2022
@leibale leibale removed the Bug label Jan 19, 2022
@leibale leibale marked this pull request as ready for review January 24, 2022 17:04
@leibale leibale merged commit 7ded3dd into redis:master Jan 24, 2022
@leibale leibale deleted the fix-1846 branch January 24, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants