Skip to content

Support BIT|BYTE option #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Support BIT|BYTE option #2035

merged 4 commits into from
Mar 24, 2022

Conversation

Avital-Fine
Copy link
Contributor

@Avital-Fine Avital-Fine commented Mar 15, 2022

Description

Two commands that support now range by a bit:

  1. BITPOS
  2. BITCOUNT

closes #1905 , closes #1907


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #2035 (57e674e) into master (be51abe) will decrease coverage by 0.23%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2035      +/-   ##
==========================================
- Coverage   94.83%   94.59%   -0.24%     
==========================================
  Files         360      362       +2     
  Lines        3366     3388      +22     
  Branches      411      415       +4     
==========================================
+ Hits         3192     3205      +13     
- Misses         89       97       +8     
- Partials       85       86       +1     
Impacted Files Coverage Δ
packages/client/lib/commands/BITCOUNT.ts 88.88% <50.00%> (-11.12%) ⬇️
packages/client/lib/commands/BITPOS.ts 100.00% <100.00%> (ø)
packages/client/lib/cluster/commands.ts 100.00% <0.00%> (ø)
packages/client/lib/commands/ZINTERCARD.ts 50.00% <0.00%> (ø)
packages/client/lib/commands/SINTERCARD.ts 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be51abe...57e674e. Read the comment docs.

@leibale leibale merged commit fe16dc0 into master Mar 24, 2022
@leibale leibale deleted the bit_range branch March 24, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants