Skip to content

Support SORT_RO #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Support SORT_RO #2041

merged 4 commits into from
Mar 28, 2022

Conversation

Avital-Fine
Copy link
Contributor

Description

SORT_RO

Closes #1972


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #2041 (4622ec2) into master (5ade5da) will decrease coverage by 0.01%.
The diff coverage is 96.66%.

❗ Current head 4622ec2 differs from pull request most recent head 5ead9be. Consider uploading reports for the commit 5ead9be to get more accurate results

@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
- Coverage   94.58%   94.56%   -0.02%     
==========================================
  Files         372      374       +2     
  Lines        3451     3461      +10     
  Branches      420      419       -1     
==========================================
+ Hits         3264     3273       +9     
- Misses        101      102       +1     
  Partials       86       86              
Impacted Files Coverage Δ
packages/client/lib/commands/SORT_RO.ts 80.00% <80.00%> (ø)
packages/client/lib/cluster/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/SORT.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/SORT_STORE.ts 100.00% <100.00%> (ø)
...ckages/client/lib/commands/generic-transformers.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ade5da...5ead9be. Read the comment docs.

@leibale leibale merged commit f6f645b into master Mar 28, 2022
@leibale leibale deleted the SORT_RO branch March 28, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for redis command: SORT_RO (R7)
3 participants