Skip to content

Add support for client.unref() and client.ref() #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

leibale
Copy link
Contributor

@leibale leibale commented Jul 12, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #2188 (dce6f00) into master (f9f5e49) will decrease coverage by 2.65%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   95.86%   93.20%   -2.66%     
==========================================
  Files         430      430              
  Lines        3964     3973       +9     
  Branches      447      448       +1     
==========================================
- Hits         3800     3703      -97     
- Misses        101      207     +106     
  Partials       63       63              
Impacted Files Coverage Δ
packages/client/lib/client/socket.ts 78.43% <71.42%> (-0.52%) ⬇️
packages/client/lib/client/index.ts 90.12% <100.00%> (-1.22%) ⬇️
packages/client/lib/commands/FUNCTION_LOAD.ts 16.66% <0.00%> (-83.34%) ⬇️
packages/client/lib/commands/FUNCTION_FLUSH.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/client/lib/commands/FUNCTION_RESTORE.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/client/lib/commands/CLIENT_NO-EVICT.ts 33.33% <0.00%> (-66.67%) ⬇️
packages/client/lib/commands/FUNCTION_LIST.ts 37.50% <0.00%> (-62.50%) ⬇️
packages/client/lib/commands/FUNCTION_STATS.ts 25.00% <0.00%> (-62.50%) ⬇️
packages/client/lib/commands/LCS_IDX.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/client/lib/commands/LCS_LEN.ts 50.00% <0.00%> (-50.00%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f5e49...dce6f00. Read the comment docs.

@leibale leibale merged commit 71d5823 into redis:master Jul 13, 2022
@leibale leibale deleted the 2185-client-unref branch January 24, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants