Fix CLUSTER_NODES ipv6 address parsing #2269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, I have found a bug with parsing ipv6 addresses from command CLUSTER NODES. This occurs because ipv6 address contains lots
:
symbols (2a02:6b8:c21:330d:0:1589:ebbe:b1a0:6379) so methodindexOf
parse just first part of ipv6 address, also afterward it produces null in port definition, finally socket can't be created and it throws an error:Before fix was made the line
'id 2a02:6b8:c21:330d:0:1589:ebbe:b1a0:6379@16379 master - 0 0 0 connected 0-549'
has beed parsed asNow it works as intended.
Also test was written.
Checklist
npm test
pass with this change (including linting)?