Reject multi.exec() promise with ClientClosedError after client disconnect
#2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabroek
changed the title
ClientClosedError after client disconnect
|
@dabroek sorry for the long delay, I was on vacation.. Nice catch! I'll merge and release it next week :) |
leibale
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I want all of the Redis commands to inform me properly when the client has been disconnected. Currently, the promise returned by the multi.exec() command is not resolving after which execution hangs.
This pull requests makes sure the promise is rejected with a
ClientClosedErrorexactly like#sendCommandis currently rejected as well when the client disconnects.Checklist
npm testpass with this change (including linting)?