Fix legacyMode/pingInterval issue #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
force-pushed
the
fix-legacy-mode-ping-interval
branch
from
e609b4e to
fe674a6
Compare
|
@benjie thanks again! I'm not sure why the tests are not passing, will check later. |
Codecov ReportBase: 95.85% // Head: 95.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
+ Coverage 95.85% 95.87% +0.02%
==========================================
Files 451 451
Lines 4247 4247
Branches 475 475
==========================================
+ Hits 4071 4072 +1
+ Misses 106 105 -1
Partials 70 70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2383 - when
pingIntervalis used with a client inlegacyModean error was thrown (see #2383) - this PR aims to resolve the issue.Checklist
npm testpass with this change (including linting)?I do not have Docker installed under WSL, so am unable to run your test suite. I was hoping CI might take care of this. You don't seem to have a
npm run formator similar command to apply autofixes to the formatting and I cannot run the test suite without Docker, so cannot confirm if linting passes.Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?