-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add support for TIMEOUT
in FT.AGGREGATE
and FT.SEARCH
#2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, check the one comment...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! :)
@leibale I just saw that one test case was failing. I missed to add one param in expected results. My bad. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2488 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 455 455
Lines 4552 4554 +2
Branches 522 523 +1
=======================================
+ Hits 4355 4357 +2
Misses 128 128
Partials 69 69
☔ View full report in Codecov by Sentry. |
is this PR good to merge? |
@Nanak360 yes :) |
TIMEOUT
in FT.AGGREGATE
and FT.SEARCH
fix #2486 - add support for
TIMEOUT
inFT.AGGREGATE
andFT.SEARCH