Skip to content

Add support for CLUSTER MYSHARDID #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Conversation

e920528
Copy link
Contributor

@e920528 e920528 commented Jun 8, 2023

Description

Fix #2457


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@leibale
Copy link
Contributor

leibale commented Jun 27, 2023

Can you please add an integration test? (using testUtils, you can use this for reference)

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a217cc1) 95.71% compared to head (a6cb891) 95.72%.
Report is 1 commits behind head on master.

❗ Current head a6cb891 differs from pull request most recent head 01bd0b6. Consider uploading reports for the commit 01bd0b6 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2528   +/-   ##
=======================================
  Coverage   95.71%   95.72%           
=======================================
  Files         458      459    +1     
  Lines        4531     4535    +4     
  Branches      506      506           
=======================================
+ Hits         4337     4341    +4     
  Misses        127      127           
  Partials       67       67           
Files Changed Coverage Δ
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/CLUSTER_MYSHARDID.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e920528
Copy link
Contributor Author

e920528 commented Jun 29, 2023

@leibale Thank you for reviewing!
I'll try to add the integration test when I have time, maybe next week.

@leibale leibale changed the title Add support for CLUSTER.MYSHARDID command Add support for CLUSTER MYSHARDID Sep 18, 2023
@leibale leibale merged commit 8ecfd3e into redis:master Sep 18, 2023
@leibale
Copy link
Contributor

leibale commented Sep 19, 2023

@e920528 [email protected]/@redis/[email protected] is on npm 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new redis command CLUSTER MYSHARDID
3 participants