Skip to content

Have client.connect() return a Promise<RedisClient> #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leibale merged 7 commits into from
Sep 18, 2023
Merged

Have client.connect() return a Promise<RedisClient> #2602

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61c5602
Connect returns the instance of the client
franciscop Aug 19, 2023
f42f774
Added a test
franciscop Aug 19, 2023
b9e9a96
No auto setup
franciscop Aug 19, 2023
77e4617
Added a bit of docs
franciscop Aug 19, 2023
3f8dbec
fix the return type, test, and the docs
leibale Aug 22, 2023
3a4fcad
fix return type
leibale Aug 22, 2023
10b411e
Update packages/client/lib/client/index.spec.ts
leibale Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/client/lib/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,11 +426,11 @@ export default class RedisClient<
});
}

async connect(): Promise<RedisClientType<M, F, S>> {
async connect() {
// see comment in constructor
this.#isolationPool ??= this.#initiateIsolationPool();
await this.#socket.connect();
return this;
return this as unknown as RedisClientType<M, F, S>;
}
Comment on lines 429 to 434
Copy link
Contributor Author

@franciscop franciscop Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am not familiar enough with TS to know if there's any meaningful difference here, but I've seen that style in the past so sounds good.


async commandsExecutor<C extends RedisCommand>(
Expand Down