Skip to content

Infer the cluster pubsub client read only mode from the node type #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Infer the cluster pubsub client read only mode from the node type #2930

merged 2 commits into from
Apr 30, 2025

Conversation

htemelski
Copy link
Collaborator

@htemelski htemelski commented Apr 30, 2025 •
edited
Loading

Description

Fix: when using s/pubsub using the cluster client, the newly created client with correctly infer the readOnly flag, based on the selected node

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@htemelski htemelski merged commit 9459660 into master Apr 30, 2025
11 checks passed
@htemelski htemelski deleted the cluster-pubsub branch April 30, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobymicroby bobymicroby bobymicroby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htemelski @bobymicroby