Skip to content

Remove unnecessary coerce to list #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Remove unnecessary coerce to list #1321

merged 1 commit into from
Apr 13, 2020

Conversation

jdufresne
Copy link
Contributor

sorted() takes any iterable and always returns a new list. No need to
eagerly coerce to a list.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Does travis tests pass with this change (enable it first in your forked repo and wait for the travis build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

sorted() takes any iterable and always returns a new list. No need to
eagerly coerce to a list.
@codecov-io
Copy link

codecov-io commented Apr 10, 2020

Codecov Report

Merging #1321 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1321   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files          19       19           
  Lines        6533     6533           
=======================================
  Hits         6064     6064           
  Misses        469      469           
Impacted Files Coverage Δ
tests/test_commands.py 99.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98242bb...ecb3ef2. Read the comment docs.

@andymccurdy
Copy link
Contributor

looks good to me, thanks!

@andymccurdy andymccurdy merged commit 1f857f0 into redis:master Apr 13, 2020
@jdufresne jdufresne deleted the sort branch April 13, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants