-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fixing the package to include commands #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
- Coverage 89.01% 88.99% -0.02%
==========================================
Files 52 52
Lines 10112 10113 +1
==========================================
- Hits 9001 9000 -1
- Misses 1111 1113 +2
Continue to review full report at Codecov.
|
This PR effectively just reverted the (good) changes in #1316 when the correct change would have been to add |
Refs redis#1316 Refs redis#1649 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]> x
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
* Switch to PEP 517 packaging using hatchling Refs #1316 Refs #1649 Remake of #2388 Co-authored-by: Ofek Lev <[email protected]> * Use a single source of truth for version info * Uninstall redis wheel installed as redis-entraid dep * Add build as dev_requirement * Get rid of requirements.txt * Get rid of setuptools and wheel deps * Move pytest configuration to pyproject.toml * Retain tests and dev_requirements.txt in sdist --------- Co-authored-by: Ofek Lev <[email protected]>
* Switch to PEP 517 packaging using hatchling Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]> * Use a single source of truth for version info * Uninstall redis wheel installed as redis-entraid dep * Add build as dev_requirement * Get rid of requirements.txt * Get rid of setuptools and wheel deps * Move pytest configuration to pyproject.toml * Retain tests and dev_requirements.txt in sdist --------- Co-authored-by: Ofek Lev <[email protected]>
Fixes #1645
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.