Async Connection: Allow PubSub.run()
without previous subscribe()
#2148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
$ tox
pass with this change (including linting)?Description of change
This change adds a "connect()" method to the PubSub class and employs that in the
run
method.This makes it possible to start a
run()
task without knowing beforehand which subscriptions are required,for example, when running a server that dynamically listens to various channels.
PR is provided as a suggested feature, and so there is no documentation or non-async implementation yet.