introduce AbstractConnection so that UnixDomainSocketConnection can call super().__init__#2588
Merged
dvora-h merged 2 commits intoredis:masterfrom Mar 16, 2023
Merged
Conversation
Codecov ReportBase: 92.31% // Head: 92.26% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2588 +/- ##
==========================================
- Coverage 92.31% 92.26% -0.06%
==========================================
Files 115 115
Lines 29744 29729 -15
==========================================
- Hits 27459 27429 -30
- Misses 2285 2300 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…all super().__init__
239c580 to
46042ce
Compare
dvora-h
approved these changes
Mar 16, 2023
This was referenced Mar 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Motivation: changes to
Connection.__init__are easily forgotten to be applied also toUnixDomainSocketConnection.__init__(for example #2570 and #2377) which leads to issues like #2581.Before this MR
After this MR