-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add support for cluster myshardid #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2288218
feat: adding support for cluster myshardid
SoulPancake 667cd98
lint fix
SoulPancake 39b14ee
Merge branch 'master' into clustermyshardid
SoulPancake b2b2efb
fix: comment fix and async test
SoulPancake aabbd0e
Merge branch 'clustermyshardid' of https://github.com/SoulPancake/red…
SoulPancake 9ec7cc8
fix: adding version check
SoulPancake 334a717
Merge branch 'master' into clustermyshardid
SoulPancake 171c1e3
fix lint:
SoulPancake 724cf46
Merge branch 'clustermyshardid' of https://github.com/SoulPancake/red…
SoulPancake eb3bc3d
Merge branch 'master' into clustermyshardid
dvora-h 121881e
linters
dvora-h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1162,6 +1162,13 @@ def test_cluster_shards(self, r): | |
for attribute in node.keys(): | ||
assert attribute in attributes | ||
|
||
@skip_if_server_version_lt("7.2.0") | ||
@skip_if_redis_enterprise() | ||
def test_cluster_myshardid(self, r): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add an async version of the test to tests/test_asyncio/test_cluster.py |
||
myshardid = r.cluster_myshardid() | ||
assert isinstance(myshardid, str) | ||
assert len(myshardid) > 0 | ||
|
||
@skip_if_redis_enterprise() | ||
def test_cluster_addslots(self, r): | ||
node = r.get_random_node() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.