Adding return types for the RedisModuleCommands class#3632
Merged
petyaslavova merged 2 commits intomasterfrom May 8, 2025
Merged
Adding return types for the RedisModuleCommands class#3632petyaslavova merged 2 commits intomasterfrom
petyaslavova merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds return type annotations to the methods of the RedisModuleCommands class and its asynchronous subclass, clarifying the API contracts for accessing various Redis module namespaces.
- Added return type hints for methods such as json, ft, ts, bf, cf, cms, topk, tdigest, and vset.
- Updated AsyncRedisModuleCommands.ft to return an AsyncSearch instance.
vladvildanov
approved these changes
May 8, 2025
Closed
petyaslavova
added a commit
to Kakadus/redis-py
that referenced
this pull request
May 13, 2025
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jun 30, 2025
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes issue #3583