Adding handling of SMIGRATED push notifications#3857
Merged
petyaslavova merged 3 commits intofeat/hitless_upgrade_sync_cluster_clientfrom Dec 1, 2025
Merged
Adding handling of SMIGRATED push notifications#3857petyaslavova merged 3 commits intofeat/hitless_upgrade_sync_cluster_clientfrom
petyaslavova merged 3 commits intofeat/hitless_upgrade_sync_cluster_clientfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces support for handling SMIGRATED push notifications in Redis cluster clients, enabling automatic cluster topology updates during slot migrations.
Key Changes
- Introduces
MaintNotificationsAbstractRedisClusterbase class for cluster maintenance notification handling - Implements
OSSMaintNotificationsHandlerto process SMIGRATED notifications and refresh cluster topology - Updates
NodesManager.initialize()to support additional startup nodes and configurable connection pool disconnection behavior during topology refresh
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
redis/cluster.py |
Adds MaintNotificationsAbstractRedisCluster abstract class and integrates OSS cluster notification handler into RedisCluster |
redis/maint_notifications.py |
Implements OSSMaintNotificationsHandler with SMIGRATED notification processing and connection pool management |
redis/connection.py |
Extends connection initialization to support OSS cluster maintenance handlers and updates configuration propagation |
redis/client.py |
Adds oss_cluster_maint_notifications_handler parameter to Redis client constructor |
redis/_parsers/base.py |
Updates notification parsing to use safe_str() for consistent string handling |
tests/maint_notifications/test_maint_notifications.py |
Updates tests for OSSNodeMigratedNotification to require node_address parameter |
tests/maint_notifications/test_cluster_maint_notifications_handling.py |
Adds comprehensive test coverage for SMIGRATING/SMIGRATED notification handling scenarios |
tests/maint_notifications/proxy_server_helpers.py |
Refactors proxy interceptor helper to support flexible cluster slot configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3c211ef to
76172f9
Compare
petyaslavova
commented
Nov 26, 2025
vladvildanov
requested changes
Nov 26, 2025
vladvildanov
approved these changes
Dec 1, 2025
d2b974d
into
feat/hitless_upgrade_sync_cluster_client
4 checks passed
petyaslavova
added a commit
that referenced
this pull request
Dec 3, 2025
* Adding SMIGRATED handling * Applying Copilot's comments * Applying review comments
petyaslavova
added a commit
that referenced
this pull request
Dec 15, 2025
* Adding SMIGRATED handling * Applying Copilot's comments * Applying review comments
petyaslavova
added a commit
that referenced
this pull request
Jan 27, 2026
* Adding SMIGRATED handling * Applying Copilot's comments * Applying review comments
petyaslavova
added a commit
that referenced
this pull request
Jan 27, 2026
* Adding SMIGRATED handling * Applying Copilot's comments * Applying review comments
petyaslavova
added a commit
that referenced
this pull request
Jan 28, 2026
* Adding SMIGRATED handling * Applying Copilot's comments * Applying review comments
petyaslavova
added a commit
that referenced
this pull request
Jan 29, 2026
* Adding SMIGRATED handling * Applying Copilot's comments * Applying review comments
petyaslavova
added a commit
that referenced
this pull request
Jan 29, 2026
* Adding SMIGRATED handling * Applying Copilot's comments * Applying review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR the following changes are introduced: