Add ssl_password support to async Redis client#3878
Merged
petyaslavova merged 4 commits intoredis:masterfrom Dec 15, 2025
Merged
Add ssl_password support to async Redis client#3878petyaslavova merged 4 commits intoredis:masterfrom
petyaslavova merged 4 commits intoredis:masterfrom
Conversation
Add ssl_password parameter to the async Redis client and SSLConnection to enable using encrypted private keys, matching the sync client's functionality. Changes: - Add ssl_password parameter to Redis.__init__ - Add ssl_password parameter to SSLConnection.__init__ - Add password parameter to RedisSSLContext - Pass password to ssl.SSLContext.load_cert_chain() 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
Hi @majiayu000, thank you for your contribution! Would you please add some unit tests that cover the change? |
Add test_ssl_password_parameter test to verify ssl_password is properly passed through to SSLConnection for encrypted private key support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Thanks for the review! I've added a unit test ( Please let me know if you'd like any additional test coverage. |
Collaborator
|
Hi @majiayu000, the change over all looks good. Can you please just fix the conflicts and we can merge this PR... |
petyaslavova
approved these changes
Dec 15, 2025
petyaslavova
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3347
Add
ssl_passwordparameter to the async Redis client and SSLConnection to enable using encrypted private keys, matching the sync client's functionality.Changes
ssl_passwordparameter toRedis.__init__ssl_passwordparameter toSSLConnection.__init__passwordparameter toRedisSSLContextssl.SSLContext.load_cert_chain()Usage
🤖 Generated with Claude Code