Skip to content

Fix unrecoverable connection state #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petyaslavova merged 6 commits into from
Jan 9, 2026
+3 −4
Merged

Fix unrecoverable connection state #3905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d72b7a9
Fix unrecoverable connection state
itssimon Jan 6, 2026
a7e3306
Merge branch 'master' into fix-redis-error-buffer-closed
petyaslavova Jan 6, 2026
aab9e6f
Raise OSError instead
itssimon Jan 6, 2026
b1c4d57
Also raise OSError in can_read_destructive() in _AsyncHiredisParser
itssimon Jan 9, 2026
58a5bd9
Raise ConnectionError in on_connect()
itssimon Jan 9, 2026
45f5efe
Merge branch 'master' into fix-redis-error-buffer-closed
itssimon Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions redis/_parsers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
NoScriptError,
OutOfMemoryError,
ReadOnlyError,
RedisError,
ResponseError,
TryAgainError,
)
Expand Down Expand Up @@ -415,7 +414,7 @@ def on_connect(self, connection):
"""Called when the stream connects"""
self._stream = connection._reader
if self._stream is None:
raise RedisError("Buffer is closed.")
raise ConnectionError(SERVER_CLOSED_CONNECTION_ERROR)
self.encoder = connection.encoder
self._clear()
self._connected = True
Expand All @@ -426,7 +425,7 @@ def on_disconnect(self):

async def can_read_destructive(self) -> bool:
if not self._connected:
raise RedisError("Buffer is closed.")
raise OSError("Buffer is closed.")
if self._buffer:
return True
try:
Expand Down
2 changes: 1 addition & 1 deletion redis/_parsers/hiredis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def on_disconnect(self):

async def can_read_destructive(self):
if not self._connected:
raise ConnectionError(SERVER_CLOSED_CONNECTION_ERROR)
raise OSError("Buffer is closed.")
if self._reader.gets() is not NOT_ENOUGH_DATA:
return True
try:
Expand Down