Fix copy-paste error in CacheProxyConnection server version check

[Nepomuk5665]

Summary

• Fix a copy-paste bug in CacheProxyConnection.connect() where the condition incorrectly checks server_ver is None or server_ver is None instead of server_ver is None or server_name is None

Bug Description

In redis/connection.py at line 1417, the validation check for server metadata has a typo where server_ver is checked twice instead of checking both server_ver and server_name.

Before:

if server_ver is None or server_ver is None:
    raise ConnectionError("Cannot retrieve information about server version")

After:

if server_ver is None or server_name is None:
    raise ConnectionError("Cannot retrieve information about server version")

Impact

This bug would allow server_name to be None without raising an error during connection validation. Later at line 1424, server_name is used in a comparison (server_name != self.DEFAULT_SERVER_NAME), which would cause unexpected behavior if server_name was None.

Testing

The fix is a simple one-character change that corrects the variable name in the condition. No new functionality is added.

[jit-ci]

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

[petyaslavova]

Hi @Nepomuk5665, thank you for your contribution! The change LGTM.