Conversation
There was a problem hiding this comment.
Pull request overview
Adds client-side support for Redis HOTKEYS commands (START/STOP/RESET/GET), including response parsing, cluster routing behavior, and test coverage across sync/async and standalone/cluster modes.
Changes:
- Added
hotkeys_start/stop/reset/getAPIs andHotkeysMetricsTypesenum to core command set. - Added response callback to parse
HOTKEYS GETinto a Python dict. - Added cluster routing logic for
HOTKEYS*commands plus extensive sync/async tests (standalone + cluster).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 28 comments.
Show a summary per file
| File | Description |
|---|---|
redis/commands/core.py |
Implements HOTKEYS command wrappers and metric enum. |
redis/_parsers/helpers.py |
Adds response callback for HOTKEYS GET parsing. |
redis/cluster.py |
Updates slot determination logic to allow HOTKEYS commands in cluster mode. |
tests/test_commands.py |
Adds standalone (sync) HOTKEYS tests. |
tests/test_asyncio/test_commands.py |
Adds standalone (async) HOTKEYS tests. |
tests/test_cluster.py |
Adds cluster (sync) HOTKEYS tests using target_nodes. |
tests/test_asyncio/test_cluster.py |
Adds cluster (async) HOTKEYS tests using target_nodes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
6400e72 to
a152432
Compare
This comment has been minimized.
This comment has been minimized.
|
augment review |
🤖 Augment PR SummarySummary: This PR adds client support for Redis 8.5+ Changes:
Technical Notes: The new HOTKEYS API is guarded by a server-version skip (8.5.240+) in tests, and 🤖 Was this summary useful? React with 👍 or 👎 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@sera ignore type:run-shell-injection |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@sera ignore type:run-shell-injection |
🛡️ Jit Security Scan Results🚨 Summary• Potential shell injection vulnerability in GitHub Actions workflow
|
Description of change
Please provide a description of the change here.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.