Refactoring the SMIGRATED flow - the notification is changed to contain the src node address for each slot range movement.#3925
Merged
petyaslavova merged 5 commits intofeat/hitless_upgrade_sync_cluster_clientfrom Feb 9, 2026
Conversation
8f550b6 to
a7ec030
Compare
…in the src node address for each slot range movement.
a7ec030 to
2ab57ee
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the SMIGRATED notification flow to include source node address information for each slot range movement. The key changes involve:
Changes:
- Modified
OSSNodeMigratedNotificationto use a list ofNodesToSlotsMappingobjects containing src_node_address, dest_node_address, and slots - Updated notification parsing to handle the new SMIGRATED message format with triplets (src_node, dest_node, slots)
- Refactored
OSSMaintNotificationsHandlerto process notifications at cluster level without per-connection handler copies - Added
__hash__methods to ClusterNode classes to support set operations - Updated tests to reflect new notification format and behavior
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| redis/maint_notifications.py | Refactored notification handling to use src node information; removed per-connection handler copies; added NodesToSlotsMapping dataclass; increased SMIGRATED TTL from 30 to 120 seconds |
| redis/connection.py | Updated handler initialization to share OSS cluster handler across connections; added maintenance state reset in disconnect() |
| redis/_parsers/base.py | Updated SMIGRATED message parsing to extract src_node, dest_node, and slots triplets; added dual handler invocation |
| redis/cluster.py, redis/asyncio/cluster.py | Added hash methods to ClusterNode for set operations |
| tests/test_scenario/test_maint_notifications.py | Major test refactoring with new parametrized tests using fault injector effects and triggers |
| tests/test_scenario/fault_injector_client.py | Added get_slot_migrate_triggers method; fixed variable naming; updated send_notification calls |
| tests/test_scenario/conftest.py | Added module-level singleton for fault injector client |
| tests/maint_notifications/test_maint_notifications.py | Updated tests for new NodesToSlotsMapping structure |
| tests/maint_notifications/test_cluster_maint_notifications_handling.py | Updated tests for new SMIGRATED format with src node information |
| tests/maint_notifications/proxy_server_helpers.py | Changed send_notification to broadcast to all connections; updated RESP translation for triplets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladvildanov
requested changes
Feb 4, 2026
vladvildanov
approved these changes
Feb 9, 2026
42f0411
into
feat/hitless_upgrade_sync_cluster_client
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Please provide a description of the change here.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.