Check Needs-Restart condition and restart pods if required #1018
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-g
requested review from
RafalKorepta,
chrisseto,
andrewstucki and
gene-redpanda
as code owners
jan-g
force-pushed
the
opv1-needs-restart
branch
5 times, most recently
from
41c1323 to
7ebcc4c
Compare
jan-g
force-pushed
the
opv1-needs-restart
branch
from
7ebcc4c to
ff136fa
Compare
chrisseto
approved these changes
Aug 6, 2025
| @@ -0,0 +1,4 @@ | |||
| project: operator | |||
| kind: Fixed | |||
| body: 'The legacy operator is more robust against configuration changes that "need restart": it will sweep over pods and mark those requiring a configuration restart according to the admin API response.' | |||
There was a problem hiding this comment.
nit: for consistency refer to it as either the vectorized operator or operator v1.
| updateForConfigRestart = true | ||
| } | ||
|
|
||
| if patchResult.IsEmpty() && !updateForConfigRestart { |
There was a problem hiding this comment.
Would you mind adding a log line here as well? Hopefully we won't hit it but it will very likely prevent a bit of hair pulling if we do find ourselves asking "why isn't the operator restarting my Pods?" again.
|
This is still not quite right. It'd be good if it were, but the sts is still stripping off the "restarting" condition for some reason, which means that all pods don't get eventually restarted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.