Skip to content

[v25.1.x] [CORE-14581] cluster: partition_balancer multiple fibers in do_tick() check #28476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillemKauf merged 2 commits into from
Nov 11, 2025
Merged

[v25.1.x] [CORE-14581] cluster: partition_balancer multiple fibers in do_tick() check #28476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98a4eae
`cluster`: move `_tick_in_progress` assignment
WillemKauf Nov 10, 2025
8696de4
`cluster`: don't allow multiple `do_tick()`s at once
WillemKauf Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/v/cluster/partition_balancer_backend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,14 @@ void partition_balancer_backend::tick() {
= ssx::spawn_with_gate_then(
_gate,
[this] {
if (_tick_in_progress) {
vlog(
clusterlog.debug,
"skipping tick, tick already in progress");
return ss::now();
}

_tick_in_progress = ss::abort_source{};
return do_tick().finally([this] {
_tick_in_progress = {};
maybe_rearm_timer(
Expand Down Expand Up @@ -344,8 +352,6 @@ ss::future<> partition_balancer_backend::do_tick() {
co_return;
}

_tick_in_progress = ss::abort_source{};

const bool force_refresh_this_tick
= _cur_term->_force_health_report_refresh;
auto health_report = co_await _health_monitor.get_cluster_health(
Expand Down