Skip to content

sec: Don't block for update on OIDC service start #28608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-redpanda merged 1 commit into from
Nov 18, 2025
Merged

sec: Don't block for update on OIDC service start #28608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/v/security/oidc_service.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ struct service::impl {
}

ss::future<> start() {
auto holder = _gate.hold();
co_await update();
ssx::spawn_with_gate(_gate, [this] { return update(); });
return ss::now();

@BenPope BenPope Nov 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just the 5s delay that causes the failed startup? I.e., does that lead to a timeout elsewhere?

@michael-redpanda michael-redpanda Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a timeout in config_manager awaiting controller leadership. This timeout is preventing controller leadership election from forming.

}
ss::future<> stop() {
_jwks_refresh.cancel();
Expand Down