sl: Fix error code on failing over non shadowed topic#28737
Merged
michael-redpanda merged 1 commit intoNov 25, 2025
Merged
Conversation
Was originally returning 409. Now returning 404. Signed-off-by: Michael Boquard <michael@redpanda.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an error code bug in the shadow link service where attempting to fail over a non-shadowed topic incorrectly returned HTTP 409 (Conflict/Already Exists) instead of HTTP 404 (Not Found).
Key Changes:
- Moved
cluster_link::errc::topic_not_being_mirroredfrom the "already exists" (409) error case to the "not found" (404) error case
rockwotj
approved these changes
Nov 25, 2025
IoannisRP
approved these changes
Nov 25, 2025
bharathv
approved these changes
Nov 25, 2025
Collaborator
CI test resultstest results on build#76963
|
Collaborator
|
/backport v25.3.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was originally returning 409. Now returning 404.
Backports Required
Release Notes
Bug Fixes
404rather than a409